Merged
Conversation
This isn't used anywhere in Cinnamon or any Xlets.
Clean up uses of Lang.bind() and clean up a few variable names and some code styling
This removes a use of CinnamonGenericContainer
We only have one unmaintained applet using this currently. For the use case of a spinner, we can add a dedicated object for that purpose. We have other uses for that.
Remove usage of Lang.bind() as well
Remove old commented out options. These have been disabled for a long time. They can be re-added if we want to bring them back.
This removes another major use of CinnamonGenericContainer. This could be taken even further, but trying to break as little as possible with this change.
This is only a partial cleanup. This file is a mess of different styles but hopefully it's at least a bit better.
mtwebster
reviewed
Mar 3, 2026
js/ui/appletManager.js
Outdated
| // so we don't need to pass it to the constructor anymore, but would | ||
| // require a compatibility clean-up effort. | ||
| applet = extension.module.main(extension.meta, orientation, panel.height, applet_id); | ||
| applet = extension.module.main(extension.meta, orientation, panel.heightForZone, applet_id); |
Contributor
Author
There was a problem hiding this comment.
Good catch. Fixed now.
Member
|
Quite a few spices check I wonder if I should flag it in our PR scanner.. edit: It looks like panel.height was the 'real' height already, though I guess vertical panels would break this... so we probably need to flag them in the scanner... |
Missed this when converting the panel to an St.Widget
Contributor
Author
|
It probably does need to be flagged. I almost left that commit out to do in a separate PR because I knew it might cause issues. Previously, panel.height() returned either the panels height or width based on the orientation. Using a variable name that shadowed an objects actual property wasn't a good choice to begin with. Now that it's an actual object, panel.height will return the panels real height regardless of orientation. That's probably not what's wanted in most cases. In summary, it had to be renamed to something that wasn't already one of the widgets actual properties. |
mtwebster
added a commit
to mtwebster/Cinnamon
that referenced
this pull request
Apr 1, 2026
Followup to linuxmint#13613. - Fix RTL swap in _calculateBoxes - Mask panel.height GObject property with a js property that prints a warning and returns the expected value (heightForZones). - Use get_height() internally to avoid this (also arguably faster) - Use get_width() internally, just for consistency. - Fix the menu applet (was still accessing panel.height).
mtwebster
added a commit
to mtwebster/Cinnamon
that referenced
this pull request
Apr 1, 2026
Followup to linuxmint#13613. - Fix RTL swap in _calculateBoxes - Mask panel.height GObject property with a js property that prints a warning and returns the expected value (heightForZones). - Use get_height() internally to avoid this (also arguably faster) - Use get_width() internally, just for consistency. - Fix the menu applet (was still accessing panel.height).
mtwebster
added a commit
to mtwebster/Cinnamon
that referenced
this pull request
Apr 1, 2026
Followup to linuxmint#13613. - Fix RTL swap in _calculateBoxes - Mask panel.height GObject property with a js property that prints a warning and recommends Applet._panelHeight, and returns the expected value (heightForZones). - Use get_height() internally to avoid this (also arguably faster) - Use get_width() internally, just for consistency. - Fix the menu applet (was still accessing panel.height).
mtwebster
added a commit
to mtwebster/Cinnamon
that referenced
this pull request
Apr 1, 2026
Followup to linuxmint#13613. - Fix RTL swap in _calculateBoxes - Mask panel.height GObject property with a js property that prints a warning and recommends Applet._panelHeight, and returns the expected value (heightForZones). - Use get_height() internally to avoid this (also arguably faster) - Use get_width() internally, just for consistency. - Fix the menu applet (was still accessing panel.height).
mtwebster
added a commit
that referenced
this pull request
Apr 1, 2026
Followup to #13613. - Fix RTL swap in _calculateBoxes - Mask panel.height GObject property with a js property that prints a warning and recommends Applet._panelHeight, and returns the expected value (heightForZones). - Use get_height() internally to avoid this (also arguably faster) - Use get_width() internally, just for consistency. - Fix the menu applet (was still accessing panel.height).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports a few more things over to classes and GObject. It removes two more uses of CinnamonGenericContainer in the PanelDummy and Panel objects. This could be taken further but doing the best I can to minimize any possible breakage.
The entire file is a bit of a mess in styling. Cleaned up a bit but it could use some more work.
Tested this quite a bit but it's possible there are a few lingering issues.